Skip to content

2 Comments

  1. ben
    February 10, 2011

    Uh, sure! Our test suite takes 75 minutes to run.

  2. February 10, 2011

    ben: you need to break out the integration tests to start with. ;)

    But I'm not saying the checkin has to wait for the tests to complete anyway -- test success is just another "vote" on the code review page, and the "approval" doesn't necessarily require a test pass. It could be that sufficient approval for a checkin just requires a developer to approve the change, or indeed that at that stage of the branch lifecycle, it's acceptable to check in immediately without any +1s (C-T-R in Apache terminology).